amaliujia commented on PR #38800: URL: https://github.com/apache/spark/pull/38800#issuecomment-1329581277
LGTM A big left work is testing coverage over literals. For example does `NaN`, `+inf`, `-inf` can pass through Connect proto and any test case? I also have a tons of questions about value range for timestamp. This is not because current PR so that is not a blocker for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org