grundprinzip commented on code in PR #38800:
URL: https://github.com/apache/spark/pull/38800#discussion_r1034096732
##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -40,37 +40,34 @@ message Expression {
message Literal {
oneof literal_type {
Review Comment:
This only works in Scala because of the inherited type hierarchy, the
ability of an Any type and deferring the necessary apply / unaply methods.
Since proto does not have this imperative concept of inheritance, we need to
embed the physical type with the logical one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
