bjornjorgensen commented on code in PR #38806:
URL: https://github.com/apache/spark/pull/38806#discussion_r1033977637
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -148,23 +148,23 @@ def selectExpr(self, *expr: Union[str, List[str]]) ->
"DataFrame":
expr = expr[0] # type: ignore[assignment]
for element in expr:
if isinstance(element, str):
- sql_expr.append(SQLExpression(element))
+ sql_expr.append(sql_expression(element))
else:
- sql_expr.extend([SQLExpression(e) for e in element])
+ sql_expr.extend([sql_expression(e) for e in element])
return DataFrame.withPlan(plan.Project(self._plan, *sql_expr),
session=self._session)
- def agg(self, *exprs: Union[Expression, Dict[str, str]]) -> "DataFrame":
+ def agg(self, *exprs: Union[Column, Dict[str, str]]) -> "DataFrame":
if not exprs:
raise ValueError("Argument 'exprs' must not be empty")
Review Comment:
must not-> can not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
