cloud-fan commented on code in PR #38806:
URL: https://github.com/apache/spark/pull/38806#discussion_r1034218435
##########
python/pyspark/sql/connect/column.py:
##########
@@ -314,3 +323,62 @@ def to_plan(self, session: "RemoteSparkSession") ->
proto.Expression:
def __str__(self) -> str:
return f"({self._op} ({', '.join([str(x) for x in self._args])}))"
+
+
+class Column(object):
Review Comment:
In Catalyst, we have to wrap `Expression` with `Column`, because
`Expression` is an internal class with many internal APIs and we can't expose
it to end users directly.
In Spark Connect, I think we can skip the wrapping if `Expression` doesn't
have any internal APIs. But end users will know we have different concrete
`Column` subclasses, which is kind of an internal detail. If this doesn't
matter, I think `Column` and `Expression` can be merged. cc @grundprinzip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
