cloud-fan commented on code in PR #38799:
URL: https://github.com/apache/spark/pull/38799#discussion_r1046753470
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -146,7 +146,9 @@ abstract class Optimizer(catalogManager: CatalogManager)
operatorOptimizationRuleSet: _*) ::
Batch("Push extra predicate through join", fixedPoint,
PushExtraPredicateThroughJoin,
- PushDownPredicates) :: Nil
+ PushDownPredicates) ::
+ Batch("Insert window group limit", Once,
+ InsertWindowGroupLimit) :: Nil
Review Comment:
is there a specific reason to put the rule here, instead of the very end of
the optimizer? e.g., right before `Batch("User Provided Optimizers",
fixedPoint, experimentalMethods.extraOptimizations: _*)` in ·SparkOptimizer·.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
