HeartSaVioR commented on code in PR #39647:
URL: https://github.com/apache/spark/pull/39647#discussion_r1080702978
##########
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala:
##########
@@ -61,6 +61,7 @@ import org.apache.spark.util.{CallSite, ShutdownHookManager,
ThreadUtils, Utils}
* `context.awaitTermination()` allows the current thread to wait for the
termination
* of the context by `stop()` or by an exception.
*/
+@deprecated
Review Comment:
https://www.scala-lang.org/api/2.12.5/scala/deprecated.html
You can give a note on the annotation.
`@deprecated("this method will be removed", "FooLib 12.0")`
Let's have a direct short message in this note (one liner, e.g. "This is
deprecated. Migrate to Structured Streaming", and in the classdoc let's find a
tag for deprecation (if there's no such thing then just start with `NOTE: `)
and have a full description. For version, Spark 3.4.0.
##########
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala:
##########
@@ -61,6 +61,7 @@ import org.apache.spark.util.{CallSite, ShutdownHookManager,
ThreadUtils, Utils}
* `context.awaitTermination()` allows the current thread to wait for the
termination
* of the context by `stop()` or by an exception.
*/
+@deprecated
Review Comment:
https://www.scala-lang.org/api/2.12.5/scala/deprecated.html
You can give a note on the annotation.
`@deprecated("this method will be removed", "FooLib 12.0")`
Let's have a direct short message in this note (one liner, e.g. "DStream is
deprecated. Migrate to Structured Streaming", and in the classdoc let's find a
tag for deprecation (if there's no such thing then just start with `NOTE: `)
and have a full description. For version, Spark 3.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
