HeartSaVioR commented on code in PR #39647:
URL: https://github.com/apache/spark/pull/39647#discussion_r1080814400
##########
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala:
##########
@@ -61,6 +61,7 @@ import org.apache.spark.util.{CallSite, ShutdownHookManager,
ThreadUtils, Utils}
* `context.awaitTermination()` allows the current thread to wait for the
termination
* of the context by `stop()` or by an exception.
*/
+@deprecated
Review Comment:
Furthermore, I just pulled the code and opened in IDEA, and looked through
the test suite. Looks like companion object needs its own deprecation
annotation. It makes sense because the class of companion object is different,
having `$` as postfix. Could you please do the same for StreamingContext
companion object as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
