xinrong-meng commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1082079721
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -217,6 +219,19 @@ message Expression {
bool is_user_defined_function = 4;
}
+ message PythonFunction {
+ bytes command = 1;
+ }
+
+ message PythonUDF {
+ string function_name = 1;
+ PythonFunction function = 2;
+ string output_type = 3;
+ repeated Expression arguments = 4;
+ int32 eval_type = 5;
+ bool deterministic = 6;
+ }
+
Review Comment:
Is there a specific reason we tag `PythonUDF ` to be `5` rather than `4`? Do
we intentionally leave it for ScalaUDF under development?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
