xinrong-meng commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1083112645
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -217,6 +218,28 @@ message Expression {
bool is_user_defined_function = 4;
}
+ message ScalarInlineUserDefinedFunction {
Review Comment:
Sounds good. How about the new ScalarInlineUserDefinedFunction as shown
below? We will serialize the existing PythonUDF message to `language_sepecific`
field then. Please let me know if that's what we want. @hvanhovell
@grundprinzip
```
message ScalarInlineUserDefinedFunction {
string function_name = 1;
bool deterministic = 2;
repeated Expression arguments = 3;
FunctionLanguage language = 4;
bytes language_sepecific = 5
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
