grundprinzip commented on code in PR #39585:
URL: https://github.com/apache/spark/pull/39585#discussion_r1083516677
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -217,6 +218,28 @@ message Expression {
bool is_user_defined_function = 4;
}
+ message ScalarInlineUserDefinedFunction {
Review Comment:
Right now the message is nested inside expression.
```
message Expression {
oneof type {
ScalarInlineUserDefinedFunction function = 1;
}
message ScalarInlineUserDefinedFunction {
}
}
```
Just move it outside, the nesting is really just for convenience and intend
and that is why it makes sense to move it outside of expression because it can
be used in both variants.
```
message Expression {
oneof type {
ScalarInlineUserDefinedFunction function = 1;
}
}
message ScalarInlineUserDefinedFunction {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
