dongjoon-hyun commented on code in PR #40072: URL: https://github.com/apache/spark/pull/40072#discussion_r1110463604
########## sql/catalyst/benchmarks/EnumTypeSetBenchmark-jdk11-results.txt: ########## @@ -1,105 +1,105 @@ -OpenJDK 64-Bit Server VM 11.0.17+8 on Linux 5.15.0-1023-azure -Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz +OpenJDK 64-Bit Server VM 11.0.18+10 on Linux 5.15.0-1031-azure +Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz Test contains use empty Set: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ -Use HashSet 4 4 0 226.9 4.4 1.0X -Use EnumSet 1 1 0 737.3 1.4 3.2X +Use HashSet 0 1 0 2440.2 0.4 1.0X +Use EnumSet 1 1 0 884.8 1.1 0.4X Review Comment: `HashSet` seems to get some improvements in this case, `contains use empty Set:`. The other cases looks in a reasonable range. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
