dongjoon-hyun commented on code in PR #40072: URL: https://github.com/apache/spark/pull/40072#discussion_r1110470216
########## sql/core/benchmarks/UpdateFieldsBenchmark-results.txt: ########## @@ -2,25 +2,25 @@ Add 2 columns and drop 2 columns at 3 different depths of nesting ================================================================================================ -OpenJDK 64-Bit Server VM 1.8.0_352-b08 on Linux 5.15.0-1023-azure +OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Add 2 columns and drop 2 columns at 3 different depths of nesting: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------------------------------- -To non-nullable StructTypes using performant method 4 6 3 0.0 Infinity 1.0X -To nullable StructTypes using performant method 3 4 1 0.0 Infinity 1.3X -To non-nullable StructTypes using non-performant method 54 63 5 0.0 Infinity 0.1X -To nullable StructTypes using non-performant method 2002 2091 127 0.0 Infinity 0.0X +To non-nullable StructTypes using performant method 6 8 3 0.0 Infinity 1.0X +To nullable StructTypes using performant method 4 5 2 0.0 Infinity 1.4X +To non-nullable StructTypes using non-performant method 68 73 5 0.0 Infinity 0.1X +To nullable StructTypes using non-performant method 2223 2452 324 0.0 Infinity 0.0X ================================================================================================ Add 50 columns and drop 50 columns at 100 different depths of nesting ================================================================================================ -OpenJDK 64-Bit Server VM 1.8.0_352-b08 on Linux 5.15.0-1023-azure +OpenJDK 64-Bit Server VM 1.8.0_362-b09 on Linux 5.15.0-1031-azure Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Add 50 columns and drop 50 columns at 100 different depths of nesting: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ----------------------------------------------------------------------------------------------------------------------------------------------------- -To non-nullable StructTypes using performant method 5520 5639 168 0.0 Infinity 1.0X -To nullable StructTypes using performant method 2657 2708 72 0.0 Infinity 2.1X +To non-nullable StructTypes using performant method 3126 3150 34 0.0 Infinity 1.0X +To nullable StructTypes using performant method 3136 4768 2309 0.0 Infinity 1.0X Review Comment: This looks like a regression in Java 8. We need to take a look at this later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
