RyanBerti commented on code in PR #40615: URL: https://github.com/apache/spark/pull/40615#discussion_r1154928718
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala: ########## @@ -0,0 +1,332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions.aggregate + +import org.apache.datasketches.hll.{HllSketch, TgtHllType, Union} +import org.apache.datasketches.memory.WritableMemory + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.{Expression, ExpressionDescription} +import org.apache.spark.sql.catalyst.trees.UnaryLike +import org.apache.spark.sql.types.{BinaryType, DataType, DoubleType, IntegerType, LongType, StringType} +import org.apache.spark.unsafe.types.UTF8String + + +/** + * This datasketchesAggregates file is intended to encapsulate all of the + * aggregate functions that utilize Datasketches sketch objects as intermediate + * aggregation buffers. + * + * The HllSketchAggregate sealed trait is meant to be extended by the aggregate + * functions which utilize instances of HllSketch to count uniques. + */ +sealed trait HllSketchAggregate + extends TypedImperativeAggregate[HllSketch] with UnaryLike[Expression] { + + // These are used as params when instantiating the HllSketch object + // and are set by the case classes' args that extend this trait + + def lgConfigK: Int + def tgtHllType: String + + // From here on, these are the shared default implementations for TypedImperativeAggregate + + /** Aggregate functions which utilize HllSketch instances should never return null */ Review Comment: Just ran a quick test, and both null and empty return 0: ` val sketch = new HllSketch() assert(sketch.getEstimate == 0) val nullString: String = null sketch.update(nullString) assert(sketch.getEstimate == 0)` ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala: ########## @@ -0,0 +1,332 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions.aggregate + +import org.apache.datasketches.hll.{HllSketch, TgtHllType, Union} +import org.apache.datasketches.memory.WritableMemory + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.{Expression, ExpressionDescription} +import org.apache.spark.sql.catalyst.trees.UnaryLike +import org.apache.spark.sql.types.{BinaryType, DataType, DoubleType, IntegerType, LongType, StringType} +import org.apache.spark.unsafe.types.UTF8String + + +/** + * This datasketchesAggregates file is intended to encapsulate all of the + * aggregate functions that utilize Datasketches sketch objects as intermediate + * aggregation buffers. + * + * The HllSketchAggregate sealed trait is meant to be extended by the aggregate + * functions which utilize instances of HllSketch to count uniques. + */ +sealed trait HllSketchAggregate + extends TypedImperativeAggregate[HllSketch] with UnaryLike[Expression] { + + // These are used as params when instantiating the HllSketch object + // and are set by the case classes' args that extend this trait + + def lgConfigK: Int + def tgtHllType: String + + // From here on, these are the shared default implementations for TypedImperativeAggregate + + /** Aggregate functions which utilize HllSketch instances should never return null */ Review Comment: Just ran a quick test, and both null and empty return 0: ``` val sketch = new HllSketch() assert(sketch.getEstimate == 0) val nullString: String = null sketch.update(nullString) assert(sketch.getEstimate == 0)``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
