cloud-fan commented on code in PR #40947:
URL: https://github.com/apache/spark/pull/40947#discussion_r1178034396
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala:
##########
@@ -265,8 +265,10 @@ object FileFormat {
* fields of the [[PartitionedFile]], and do have entries in the file's
metadata map.
*/
val BASE_METADATA_EXTRACTORS: Map[String, PartitionedFile => Any] = Map(
- FILE_PATH -> { pf: PartitionedFile => pf.toPath.toString },
- FILE_NAME -> { pf: PartitionedFile => pf.toPath.getName },
+ FILE_PATH -> { pf: PartitionedFile => pf.filePath.urlEncoded },
+ FILE_NAME -> { pf: PartitionedFile =>
+ pf.filePath.toUri.getRawPath.split("/").lastOption.getOrElse("")
Review Comment:
I prefer this way as I think ideally `new Path(String)` should take the
unencoded path string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
