databricks-david-lewis commented on PR #40947:
URL: https://github.com/apache/spark/pull/40947#issuecomment-1534129513
Oof. This is because of the following:
```
val p1 = new Path("file:///a")
val p2 = new Path("file:/a")
p1 == p2
p1.toString == p2.toString
p1.toUri == p2.toUri
// but...
p1.toUri.toString != p2.toUri.toString // "file:///a" != "file:/a"
```
Before any of my changes, we were doing `new Path(uriString).toString` which
would "normalize" the uri string.
Should we do the same here? Seems silly...
I could also update the test to explicitly pass in `file:/...` ...
Thoughts @cloud-fan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
