hvanhovell commented on code in PR #40796: URL: https://github.com/apache/spark/pull/40796#discussion_r1183189886
########## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/UdfUtils.scala: ########## @@ -95,5 +95,11 @@ private[sql] object UdfUtils extends Serializable { } } + def mapReduceFuncToScalaFunc[T](func: ReduceFunction[T]): (T, T) => T = func.call + + def groupAllUnderBoolTrue[T](): T => Boolean = _ => true + def identical[T](): T => T = t => t + + def as[V, K](): V => K = v => v.asInstanceOf[K] Review Comment: This should be a no-op because of type erasure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org