hvanhovell commented on code in PR #40796: URL: https://github.com/apache/spark/pull/40796#discussion_r1183901421
########## connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala: ########## @@ -1867,7 +1928,34 @@ class SparkConnectPlanner(val session: SparkSession) { output.logicalPlan } + def transformKeyValueGroupedAggregate(rel: proto.Aggregate): LogicalPlan = { + val ds = UntypedKeyValueGroupedDataset( + rel.getInput, + rel.getGroupingExpressionsList, + java.util.Collections.emptyList()) + + val namedColumns = rel.getAggregateExpressionsList.asScala.toSeq.map(expr => { Review Comment: This currently does not work with mapValues right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org