gengliangwang commented on code in PR #41191:
URL: https://github.com/apache/spark/pull/41191#discussion_r1201267669
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -1389,4 +1389,8 @@ case class TableSpec(
location: Option[String],
comment: Option[String],
serde: Option[SerdeInfo],
- external: Boolean)
+ external: Boolean,
+ // If non-empty, this contains the values of the 'options' list as parsed
but unresolved
+ // expressions. The analyzer will then constant-fold them to literals and
clear this field,
+ // assigning the result to 'options'.
+ unresolvedOptions: Map[String, Option[Expression]] = Map.empty)
Review Comment:
Why `Option[Expression]`? Can we make it `Map[String, Expression]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
