anchovYu commented on code in PR #41864:
URL: https://github.com/apache/spark/pull/41864#discussion_r1259998570
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala:
##########
@@ -208,3 +209,20 @@ case class CountMinSketchAgg(
confidenceExpression = third,
seedExpression = fourth)
}
+
+object CountMinSketchAggExpressionBuilder extends ExpressionBuilder {
+ final val functionSignature = FunctionSignature(Seq(
+ NamedArgument("column",
+ FixedArgumentType(TypeCollection(IntegralType, StringType,
BinaryType))),
+ NamedArgument("epsilon", FixedArgumentType(DoubleType)),
+ NamedArgument("confidence", FixedArgumentType(DoubleType)),
+ NamedArgument("seed", FixedArgumentType(IntegerType))
Review Comment:
I don't think the new framework will check the data types or the input
requirements - this will still be the responsibility and functionality of
original `checkInputDataTypes`. The new framework basically just reorder the
arguments based on the **names**. In the current implementation it doesn't
really use the type information in the signatures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
