learningchess2003 commented on code in PR #41864:
URL: https://github.com/apache/spark/pull/41864#discussion_r1261774415
##########
sql/core/src/test/resources/sql-tests/results/named-function-arguments.sql.out:
##########
@@ -2,121 +2,258 @@
-- !query
SELECT mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q', otherChar =>
'o', digitChar => 'd')
-- !query schema
+struct<mask(AbCD123-@$#, Q, q, d, o):string>
+-- !query output
+QqQQdddoooo
+
+
+-- !query
+SELECT mask(lowerChar => 'q', upperChar => 'Q', otherChar => 'o', digitChar =>
'd', str => 'AbCD123-@$#')
+-- !query schema
+struct<mask(AbCD123-@$#, Q, q, d, o):string>
+-- !query output
+QqQQdddoooo
+
+
+-- !query
+SELECT mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q', digitChar =>
'd')
+-- !query schema
+struct<mask(AbCD123-@$#, Q, q, d, NULL):string>
+-- !query output
+QqQQddd-@$#
+
+
+-- !query
+SELECT mask(lowerChar => 'q', upperChar => 'Q', digitChar => 'd', str =>
'AbCD123-@$#')
+-- !query schema
+struct<mask(AbCD123-@$#, Q, q, d, NULL):string>
+-- !query output
+QqQQddd-@$#
+
+
+-- !query
+create temporary view t2 as select * from values
+ ('val2a', 6S, 12, 14L, float(15), 20D, 20E2, timestamp '2014-04-04
01:01:00.000', date '2014-04-04'),
+ ('val1b', 10S, 12, 19L, float(17), 25D, 26E2, timestamp '2014-05-04
01:01:00.000', date '2014-05-04'),
+ ('val1b', 8S, 16, 119L, float(17), 25D, 26E2, timestamp '2015-05-04
01:01:00.000', date '2015-05-04'),
+ ('val1c', 12S, 16, 219L, float(17), 25D, 26E2, timestamp '2016-05-04
01:01:00.000', date '2016-05-04'),
+ ('val1b', null, 16, 319L, float(17), 25D, 26E2, timestamp '2017-05-04
01:01:00.000', null),
+ ('val2e', 8S, null, 419L, float(17), 25D, 26E2, timestamp '2014-06-04
01:01:00.000', date '2014-06-04'),
+ ('val1f', 19S, null, 519L, float(17), 25D, 26E2, timestamp '2014-05-04
01:01:00.000', date '2014-05-04'),
+ ('val1b', 10S, 12, 19L, float(17), 25D, 26E2, timestamp '2014-06-04
01:01:00.000', date '2014-06-04'),
+ ('val1b', 8S, 16, 19L, float(17), 25D, 26E2, timestamp '2014-07-04
01:01:00.000', date '2014-07-04'),
+ ('val1c', 12S, 16, 19L, float(17), 25D, 26E2, timestamp '2014-08-04
01:01:00.000', date '2014-08-05'),
+ ('val1e', 8S, null, 19L, float(17), 25D, 26E2, timestamp '2014-09-04
01:01:00.000', date '2014-09-04'),
+ ('val1f', 19S, null, 19L, float(17), 25D, 26E2, timestamp '2014-10-04
01:01:00.000', date '2014-10-04'),
+ ('val1b', null, 16, 19L, float(17), 25D, 26E2, timestamp '2014-05-04
01:01:00.000', null)
+ as t2(t2a, t2b, t2c, t2d, t2e, t2f, t2g, t2h, t2i)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+SELECT hex(count_min_sketch(t2d, seed => 1, epsilon => 0.5d, confidence =>
0.5d)) FROM t2
+-- !query schema
+struct<hex(count_min_sketch(t2d, 0.5, 0.5, 1)):string>
+-- !query output
+00000001000000000000000D0000000100000004000000005D8D6AB90000000000000002000000000000000700000000000000010000000000000003
+
+
+-- !query
+SELECT hex(count_min_sketch(seed => 1, epsilon => 0.5d, confidence => 0.5d,
column => t2d)) FROM t2
+-- !query schema
+struct<hex(count_min_sketch(t2d, 0.5, 0.5, 1)):string>
+-- !query output
+00000001000000000000000D0000000100000004000000005D8D6AB90000000000000002000000000000000700000000000000010000000000000003
+
+
+-- !query
+SELECT hex(count_min_sketch(t2d, 0.5d, seed => 1, confidence => 0.5d)) FROM t2
+-- !query schema
+struct<hex(count_min_sketch(t2d, 0.5, 0.5, 1)):string>
+-- !query output
+00000001000000000000000D0000000100000004000000005D8D6AB90000000000000002000000000000000700000000000000010000000000000003
+
+
+-- !query
+SELECT * FROM explode(collection => array(1, 2))
+-- !query schema
+struct<col:int>
+-- !query output
+1
+2
+
+
+-- !query
+SELECT * FROM explode_outer(collection => map('a', 1, 'b', 2))
+-- !query schema
+struct<key:string,value:int>
+-- !query output
+a 1
+b 2
+
+
+-- !query
+CREATE OR REPLACE TEMPORARY VIEW v AS SELECT id FROM range(0, 8)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+SELECT * FROM explode(collection => TABLE v)
+-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "DATATYPE_MISMATCH.NON_FOLDABLE_INPUT",
+ "errorClass" : "DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE",
"sqlState" : "42K09",
"messageParameters" : {
- "inputExpr" : "\"namedargumentexpression(q)\"",
- "inputName" : "upperChar",
- "inputType" : "\"STRING\"",
- "sqlExpr" : "\"mask(AbCD123-@$#, namedargumentexpression(q),
namedargumentexpression(Q), namedargumentexpression(o),
namedargumentexpression(d))\""
+ "inputSql" : "\"outer(__auto_generated_subquery_name_0.c)\"",
+ "inputType" : "\"STRUCT<id: BIGINT>\"",
+ "paramIndex" : "1",
+ "requiredType" : "(\"ARRAY\" or \"MAP\")",
+ "sqlExpr" : "\"explode(outer(__auto_generated_subquery_name_0.c))\""
+ },
+ "queryContext" : [ {
+ "objectType" : "",
+ "objectName" : "",
+ "startIndex" : 15,
+ "stopIndex" : 44,
+ "fragment" : "explode(collection => TABLE v)"
+ } ]
+}
+
+
+-- !query
+SELECT mask(lowerChar => 'q', 'AbCD123-@$#', upperChar => 'Q', otherChar =>
'o', digitChar => 'd')
+-- !query schema
+struct<>
+-- !query output
+org.apache.spark.sql.AnalysisException
+{
+ "errorClass" : "UNEXPECTED_POSITIONAL_ARGUMENT",
+ "sqlState" : "4274K",
+ "messageParameters" : {
+ "functionName" : "`mask`"
},
"queryContext" : [ {
"objectType" : "",
"objectName" : "",
"startIndex" : 8,
"stopIndex" : 98,
- "fragment" : "mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q',
otherChar => 'o', digitChar => 'd')"
+ "fragment" : "mask(lowerChar => 'q', 'AbCD123-@$#', upperChar => 'Q',
otherChar => 'o', digitChar => 'd')"
} ]
}
-- !query
-SELECT mask(lowerChar => 'q', upperChar => 'Q', otherChar => 'o', digitChar =>
'd', str => 'AbCD123-@$#')
+SELECT mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q', otherChar =>
'o', digitChar => 'd', digitChar => 'e')
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "DATATYPE_MISMATCH.NON_FOLDABLE_INPUT",
- "sqlState" : "42K09",
+ "errorClass" :
"DUPLICATE_ROUTINE_PARAMETER_ASSIGNMENT.DOUBLE_NAMED_ARGUMENT_REFERENCE",
+ "sqlState" : "4274K",
"messageParameters" : {
- "inputExpr" : "\"namedargumentexpression(Q)\"",
- "inputName" : "upperChar",
- "inputType" : "\"STRING\"",
- "sqlExpr" : "\"mask(namedargumentexpression(q),
namedargumentexpression(Q), namedargumentexpression(o),
namedargumentexpression(d), namedargumentexpression(AbCD123-@$#))\""
+ "functionName" : "`mask`",
+ "parameterName" : "`digitChar`"
},
"queryContext" : [ {
"objectType" : "",
"objectName" : "",
"startIndex" : 8,
- "stopIndex" : 105,
- "fragment" : "mask(lowerChar => 'q', upperChar => 'Q', otherChar => 'o',
digitChar => 'd', str => 'AbCD123-@$#')"
+ "stopIndex" : 116,
+ "fragment" : "mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q',
otherChar => 'o', digitChar => 'd', digitChar => 'e')"
} ]
}
-- !query
-SELECT mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q', digitChar =>
'd')
+SELECT mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q', otherChar =>
'o', digitChar => 'd', str => 'AbC')
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "DATATYPE_MISMATCH.NON_FOLDABLE_INPUT",
- "sqlState" : "42K09",
+ "errorClass" :
"DUPLICATE_ROUTINE_PARAMETER_ASSIGNMENT.POSITIONAL_AND_NAMED_ARGUMENT_DOUBLE_REFERENCE",
+ "sqlState" : "4274K",
"messageParameters" : {
- "inputExpr" : "\"namedargumentexpression(q)\"",
- "inputName" : "upperChar",
- "inputType" : "\"STRING\"",
- "sqlExpr" : "\"mask(AbCD123-@$#, namedargumentexpression(q),
namedargumentexpression(Q), namedargumentexpression(d), NULL)\""
+ "functionName" : "`mask`",
+ "parameterName" : "`str`"
},
"queryContext" : [ {
"objectType" : "",
"objectName" : "",
"startIndex" : 8,
- "stopIndex" : 80,
- "fragment" : "mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q',
digitChar => 'd')"
+ "stopIndex" : 112,
+ "fragment" : "mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q',
otherChar => 'o', digitChar => 'd', str => 'AbC')"
} ]
}
-- !query
-SELECT mask(lowerChar => 'q', upperChar => 'Q', digitChar => 'd', str =>
'AbCD123-@$#')
+SELECT mask(lowerChar => 'q', upperChar => 'Q', otherChar => 'o', digitChar =>
'd')
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "DATATYPE_MISMATCH.NON_FOLDABLE_INPUT",
- "sqlState" : "42K09",
+ "errorClass" : "REQUIRED_PARAMETER_NOT_FOUND",
+ "sqlState" : "4274K",
"messageParameters" : {
- "inputExpr" : "\"namedargumentexpression(Q)\"",
- "inputName" : "upperChar",
- "inputType" : "\"STRING\"",
- "sqlExpr" : "\"mask(namedargumentexpression(q),
namedargumentexpression(Q), namedargumentexpression(d),
namedargumentexpression(AbCD123-@$#), NULL)\""
+ "functionName" : "`mask`",
+ "parameterName" : "`str`"
},
"queryContext" : [ {
"objectType" : "",
"objectName" : "",
"startIndex" : 8,
- "stopIndex" : 87,
- "fragment" : "mask(lowerChar => 'q', upperChar => 'Q', digitChar => 'd',
str => 'AbCD123-@$#')"
+ "stopIndex" : 83,
+ "fragment" : "mask(lowerChar => 'q', upperChar => 'Q', otherChar => 'o',
digitChar => 'd')"
} ]
}
-- !query
-SELECT mask(lowerChar => 'q', 'AbCD123-@$#', upperChar => 'Q', otherChar =>
'o', digitChar => 'd')
+SELECT mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q', otherChar =>
'o', digitChar => 'd', cellular => 'automata')
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
- "errorClass" : "DATATYPE_MISMATCH.INPUT_SIZE_NOT_ONE",
- "sqlState" : "42K09",
+ "errorClass" : "UNRECOGNIZED_PARAMETER_NAME",
+ "sqlState" : "4274K",
"messageParameters" : {
- "exprName" : "upperChar",
- "sqlExpr" : "\"mask(namedargumentexpression(q), AbCD123-@$#,
namedargumentexpression(Q), namedargumentexpression(o),
namedargumentexpression(d))\""
+ "argumentName" : "`cellular`",
+ "functionName" : "`mask`",
+ "proposal" : "`str` `upperChar` `otherChar` "
},
"queryContext" : [ {
"objectType" : "",
"objectName" : "",
"startIndex" : 8,
- "stopIndex" : 98,
- "fragment" : "mask(lowerChar => 'q', 'AbCD123-@$#', upperChar => 'Q',
otherChar => 'o', digitChar => 'd')"
+ "stopIndex" : 122,
+ "fragment" : "mask('AbCD123-@$#', lowerChar => 'q', upperChar => 'Q',
otherChar => 'o', digitChar => 'd', cellular => 'automata')"
} ]
}
+
+
+-- !query
+SELECT encode(str => 'a', charset => 'utf-8')
+-- !query schema
+struct<>
+-- !query output
+org.apache.spark.SparkException
+{
+ "errorClass" : "INTERNAL_ERROR",
+ "sqlState" : "XX000",
+ "messageParameters" : {
+ "message" : "Cannot generate code for expression: str => a"
Review Comment:
Oh, this needs to be fixed. This should definitely be
NAMED_ARGUMENTS_NOT_SUPPORTED. I don't think I've done that yet with this
framework. Will need to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
