zekai-li commented on code in PR #42529:
URL: https://github.com/apache/spark/pull/42529#discussion_r1299645037
##########
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:
##########
@@ -685,9 +685,9 @@ class ClientSuite extends SparkFunSuite with Matchers {
("files URI unmatch test1", "file:///file1", "file://host/file2"),
("files URI unmatch test2", "file://host/file1", "file:///file2"),
("files URI unmatch test3", "file://host/file1", "file://host2/file2"),
- ("wasb URI unmatch test1", "wasb://bucket1@user", "wasb://bucket2@user/"),
- ("wasb URI unmatch test2", "wasb://bucket1@user", "wasb://bucket1@user2/"),
- ("s3 URI unmatch test", "s3a://user@pass:bucket1/",
"s3a://user2@pass2:bucket1/"),
+ ("wasb URI unmatch test1", "wasb://user@bucket1", "wasb://user@bucket2/"),
+ ("wasb URI unmatch test2", "wasb://user@bucket1", "wasb://user2@bucket1/"),
+ ("s3 URI unmatch test", "s3a://user:pass@bucket1/",
"s3a://user2:pass2@bucket1/"),
("hdfs URI unmatch test1", "hdfs://namenode1/path1",
"hdfs://namenode1:8080/path2"),
("hdfs URI unmatch test2", "hdfs://namenode1:8020/path1",
"hdfs://namenode1:8080/path2")
Review Comment:
I added a test data for match：hdfs://localhost:8080 hdfs://127.0.0.1:8080
##########
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala:
##########
@@ -685,9 +685,9 @@ class ClientSuite extends SparkFunSuite with Matchers {
("files URI unmatch test1", "file:///file1", "file://host/file2"),
("files URI unmatch test2", "file://host/file1", "file:///file2"),
("files URI unmatch test3", "file://host/file1", "file://host2/file2"),
- ("wasb URI unmatch test1", "wasb://bucket1@user", "wasb://bucket2@user/"),
- ("wasb URI unmatch test2", "wasb://bucket1@user", "wasb://bucket1@user2/"),
- ("s3 URI unmatch test", "s3a://user@pass:bucket1/",
"s3a://user2@pass2:bucket1/"),
+ ("wasb URI unmatch test1", "wasb://user@bucket1", "wasb://user@bucket2/"),
+ ("wasb URI unmatch test2", "wasb://user@bucket1", "wasb://user2@bucket1/"),
+ ("s3 URI unmatch test", "s3a://user:pass@bucket1/",
"s3a://user2:pass2@bucket1/"),
("hdfs URI unmatch test1", "hdfs://namenode1/path1",
"hdfs://namenode1:8080/path2"),
("hdfs URI unmatch test2", "hdfs://namenode1:8020/path1",
"hdfs://namenode1:8080/path2")
Review Comment:
I added a test data for match：hdfs://localhost:8080 hdfs://127.0.0.1:8080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
