dongjoon-hyun commented on code in PR #42674: URL: https://github.com/apache/spark/pull/42674#discussion_r1305825910
########## sql/core/src/test/scala/org/apache/spark/sql/execution/ui/UISeleniumSuite.scala: ########## @@ -103,4 +113,16 @@ class UISeleniumSuite extends SparkFunSuite with WebBrowser { assert(planDetails.head.contains("TABLE_OR_VIEW_NOT_FOUND")) } } + + test("Escape html is not necessary") { + spark = creatSparkSessionWithUI + val escape = (BASIC_ESCAPE.keySet().asScala.toSeq ++ ISO8859_1_ESCAPE.keySet().asScala ++ + HTML40_EXTENDED_ESCAPE.keySet().asScala).mkString + val errorMsg = escapeJava(escape.mkString) + intercept[Exception](spark.sql(s"SELECT raise_error('$errorMsg')").collect()) Review Comment: Although we don't care about the exceptions, shall we? - `RuntimeException` instead of `Exception`? - Check the error message? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org