heyihong commented on code in PR #42377:
URL: https://github.com/apache/spark/pull/42377#discussion_r1310938778
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -201,6 +201,20 @@ class SparkConnectService(debug: Boolean) extends
AsyncService with BindableServ
sessionId = request.getSessionId)
}
+ override def getErrorInfo(
+ request: proto.GetErrorInfoRequest,
+ responseObserver: StreamObserver[proto.GetErrorInfoResponse]): Unit = {
+ try {
+ new SparkConnectGetErrorInfoHandler(responseObserver).handle(request)
+ } catch {
+ ErrorUtils.handleError(
+ "getErrorInfo",
+ observer = responseObserver,
+ userId = request.getUserContext.getUserId,
+ sessionId = request.getSessionId)
Review Comment:
The idea is to make the ErrorInfo self-contained for issuing
FetchErrorDetails request. Otherwise, it may make the implementation on the
client side a bit more complicate since each FetchErrorDetails call needs to
figure out the corresponding session id and user id
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -201,6 +201,20 @@ class SparkConnectService(debug: Boolean) extends
AsyncService with BindableServ
sessionId = request.getSessionId)
}
+ override def getErrorInfo(
+ request: proto.GetErrorInfoRequest,
+ responseObserver: StreamObserver[proto.GetErrorInfoResponse]): Unit = {
+ try {
+ new SparkConnectGetErrorInfoHandler(responseObserver).handle(request)
+ } catch {
+ ErrorUtils.handleError(
+ "getErrorInfo",
+ observer = responseObserver,
+ userId = request.getUserContext.getUserId,
+ sessionId = request.getSessionId)
Review Comment:
The idea is to make the ErrorInfo self-contained for issuing the follow up
FetchErrorDetails request. Otherwise, it may make the implementation on the
client side a bit more complicate since each FetchErrorDetails call needs to
figure out the corresponding session id and user id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
