heyihong commented on code in PR #42377: URL: https://github.com/apache/spark/pull/42377#discussion_r1311420355
########## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala: ########## @@ -64,6 +69,94 @@ private[client] object GrpcExceptionConverter extends JsonUtils { } } + private def enrichError(errors: Array[Error], info: ErrorInfo): Array[Error] = { + val sessionId = info.getMetadataOrDefault("sessionId", null) + val userId = info.getMetadataOrDefault("userId", null) Review Comment: @hvanhovell Would like to know your thoughts on this ########## connector/connect/common/src/main/protobuf/spark/connect/base.proto: ########## @@ -778,6 +778,62 @@ message ReleaseExecuteResponse { optional string operation_id = 2; } +// GetErrorInfoRequest defines criteria for retrieving cached exceptions. +message GetErrorInfoRequest { + + // (Required) + // + // The session_id specifies a spark session for a user id (which is specified + // by user_context.user_id). + // The id should be an UUID string of the format `00112233-4455-6677-8899-aabbccddeeff` + string session_id = 1; + + // User context + UserContext user_context = 2; + + // (Required) + // Provide a list of error ids to get. + repeated string error_ids = 3; Review Comment: @hvanhovell Would like to know your thoughts on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org