cloud-fan commented on PR #42797: URL: https://github.com/apache/spark/pull/42797#issuecomment-1707963737
given the amount of changes, I'm rethinking about what's the right behavior. Looking at `Expression#prettyName`, it does seem like we prefer lower-cased names for functions. But we can't say that it's wrong to use upper-cased names for math functions. Shall we just follow the existing naming style? Math functions prefer upper-cased names and we should update `UnaryMathExpression#prettyName` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
