cloud-fan commented on code in PR #42797: URL: https://github.com/apache/spark/pull/42797#discussion_r1317406794
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala: ########## @@ -1479,6 +1480,10 @@ abstract class RoundBase(child: Expression, scale: Expression, override def foldable: Boolean = child.foldable + override def prettyName: String = Review Comment: we can leave a comment to say that other math functions also use upper-cased names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
