HyukjinKwon commented on code in PR #42938: URL: https://github.com/apache/spark/pull/42938#discussion_r1326886753
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ########## @@ -830,7 +830,11 @@ object FunctionRegistry { // csv expression[CsvToStructs]("from_csv"), expression[SchemaOfCsv]("schema_of_csv"), - expression[StructsToCsv]("to_csv") + expression[StructsToCsv]("to_csv"), + + // Xml + expression[XmlToStructs] ("from_xml"), Review Comment: To register this properly, I think `XmlToStructs` has to be decorated by `ExpressionDescription` like you did in `SchemaOfXml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org