itholic commented on code in PR #42938:
URL: https://github.com/apache/spark/pull/42938#discussion_r1327925718
##########
python/pyspark/sql/tests/test_functions.py:
##########
@@ -1286,6 +1281,27 @@ def test_from_csv(self):
message_parameters={"arg_name": "schema", "arg_type": "int"},
)
+ def test_schema_of_xml(self):
Review Comment:
I think we might need to test for non-connect as well??
Seems like we only compare between connect <> non-connect from
`python/pyspark/sql/tests/connect/test_connect_function.py` by using
`compare_by_show `, but maybe the test for data correctness is missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
