HyukjinKwon commented on code in PR #42938:
URL: https://github.com/apache/spark/pull/42938#discussion_r1328194879
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/FunctionTestSuite.scala:
##########
@@ -229,6 +229,18 @@ class FunctionTestSuite extends ConnectFunSuite {
schema_of_csv("x,y"),
schema_of_csv(lit("x,y"), Collections.emptyMap()))
testEquals("to_csv", to_csv(a), to_csv(a, Collections.emptyMap[String,
String]))
+ testEquals(
+ "from_xml",
+ from_xml(a, schema),
+ from_xml(a, lit(schema.toDDL)),
+ // from_xml(a, lit(schema.json)),
Review Comment:
Using JSON as its schema is discouraged actually. I think you can just
remove it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
