peter-toth commented on code in PR #42864: URL: https://github.com/apache/spark/pull/42864#discussion_r1328386268
########## sql/core/src/main/scala/org/apache/spark/sql/functions.scala: ########## @@ -6843,9 +6562,8 @@ object functions { * @since 3.0.0 */ // scalastyle:on line.size.limit - def schema_of_json(json: Column, options: java.util.Map[String, String]): Column = { - withExpr(SchemaOfJson(json.expr, options.asScala.toMap)) - } + def schema_of_json(json: Column, options: java.util.Map[String, String]): Column = Review Comment: No sure I get your point. `SchemaOfJson` seems to accept options as expressions: https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala#L776-L778. We just follow Connect here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org