peter-toth commented on code in PR #42864:
URL: https://github.com/apache/spark/pull/42864#discussion_r1331113924
##########
python/pyspark/sql/column.py:
##########
@@ -712,11 +712,11 @@ def __getitem__(self, k: Any) -> "Column":
--------
>>> df = spark.createDataFrame([('abcedfg', {"key": "value"})], ["l",
"d"])
>>> df.select(df.l[slice(1, 3)], df.d['key']).show()
- +------------------+------+
- |substring(l, 1, 3)|d[key]|
- +------------------+------+
- | abc| value|
- +------------------+------+
+ +---------------+------+
+ |substr(l, 1, 3)|d[key]|
Review Comment:
I tried `self.substring` (see
https://github.com/apache/spark/pull/42864/commits/d611fd5a8da8f0f24d54c3933b3cf7e4dbdabe2c)
but there is no `self.substring` so reverted it in
https://github.com/apache/spark/pull/42864/commits/6bd03d11b4d345ef0d571976ab80a99002a7ca75.
If column name doesn't matter then let's use `self.substr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
