vsevolodstep-db commented on code in PR #43354:
URL: https://github.com/apache/spark/pull/43354#discussion_r1361934438
##########
common/utils/pom.xml:
##########
@@ -51,6 +51,20 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-text</artifactId>
</dependency>
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.ivy</groupId>
+ <artifactId>ivy</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>oro</groupId>
Review Comment:
glob matchers (`ivySettings.getMatcher("glob")`) require oro
https://ant.apache.org/ivy/history/latest-milestone/concept.html
Also if I remove this dep then tests start failing:
```
[error] Uncaught exception when running
org.apache.spark.util.MavenUtilsSuite: java.lang.NoClassDefFoundError:
org/apache/oro/text/regex/MalformedPatternException
[error] sbt.ForkMain$ForkError: java.lang.NoClassDefFoundError:
org/apache/oro/text/regex/MalformedPatternException
[error] at
org.apache.ivy.plugins.matcher.GlobPatternMatcher.newMatcher(GlobPatternMatcher.java:57)
[error] at
org.apache.ivy.plugins.matcher.AbstractPatternMatcher.getMatcher(AbstractPatternMatcher.java:44)
[error] at
org.apache.ivy.plugins.matcher.MatcherHelper.matches(MatcherHelper.java:34)
[error] at
org.apache.ivy.plugins.matcher.MatcherHelper.matches(MatcherHelper.java:39)
[error] at
org.apache.ivy.plugins.matcher.MatcherHelper.matches(MatcherHelper.java:49)
[error] at
org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor.doesExclude(DefaultModuleDescriptor.java:783)
[error] at
org.apache.ivy.core.resolve.IvyNode.directlyExcludes(IvyNode.java:439)
[error] at
org.apache.ivy.core.resolve.IvyNode.doesExclude(IvyNode.java:421)
[error] at
org.apache.ivy.core.resolve.IvyNode.isDependencyModuleExcluded(IvyNode.java:411)
[error] at
org.apache.ivy.core.resolve.IvyNode.getDependencies(IvyNode.java:361)
[error] at
org.apache.ivy.core.resolve.VisitNode.getDependencies(VisitNode.java:305)
[error] at
org.apache.ivy.core.resolve.ResolveEngine.doFetchDependencies(ResolveEngine.java:797)
[error] at
org.apache.ivy.core.resolve.ResolveEngine.fetchDependencies(ResolveEngine.java:729)
[error] at
org.apache.ivy.core.resolve.ResolveEngine.getDependencies(ResolveEngine.java:607)
[error] at
org.apache.ivy.core.resolve.ResolveEngine.resolve(ResolveEngine.java:250)
[error] at org.apache.ivy.Ivy.resolve(Ivy.java:522)
[error] at
org.apache.spark.util.MavenUtils$.resolveMavenCoordinates(MavenUtils.scala:456)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
