HyukjinKwon commented on code in PR #43354:
URL: https://github.com/apache/spark/pull/43354#discussion_r1361984474
##########
common/utils/src/test/scala/org/apache/spark/util/MavenUtilsSuite.scala:
##########
@@ -248,15 +252,18 @@ class SparkSubmitUtilsSuite extends SparkFunSuite {
val settingsFile = Paths.get(tempIvyPath, "ivysettings.xml")
Files.write(settingsFile, settingsText.getBytes(StandardCharsets.UTF_8))
- val settings = SparkSubmitUtils.loadIvySettings(settingsFile.toString,
None, None)
- settings.setDefaultIvyUserDir(new File(tempIvyPath)) // NOTE - can't set
this through file
+ val settings = MavenUtils.loadIvySettings(settingsFile.toString, None,
None)
+ settings.setDefaultIvyUserDir(new File(tempIvyPath)) // NOTE - can't set
this through file
val testUtilSettings = new IvySettings
testUtilSettings.setDefaultIvyUserDir(new File(tempIvyPath))
IvyTestUtils.withRepository(main, Some(dep), Some(dummyIvyLocal),
useIvyLayout = true,
ivySettings = testUtilSettings) { repo =>
- val jarPath = SparkSubmitUtils.resolveMavenCoordinates(main.toString,
settings,
- transitive = true, isTest = true)
+ val jarPath = MavenUtils.resolveMavenCoordinates(
+ main.toString,
+ settings,
+ transitive = true,
+ isTest = true)
Review Comment:
I know it's troublesome but let's just revert all these formatting changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
