viirya commented on code in PR #43694:
URL: https://github.com/apache/spark/pull/43694#discussion_r1384417670
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOffSuite.scala:
##########
@@ -514,9 +514,9 @@ class CastWithAnsiOffSuite extends CastSuiteBase {
val negativeTs = Timestamp.valueOf("1900-05-05 18:34:56.1")
assert(negativeTs.getTime < 0)
val expectedSecs = Math.floorDiv(negativeTs.getTime, MILLIS_PER_SECOND)
- checkEvaluation(cast(negativeTs, ByteType), expectedSecs.toByte)
- checkEvaluation(cast(negativeTs, ShortType), expectedSecs.toShort)
- checkEvaluation(cast(negativeTs, IntegerType), expectedSecs.toInt)
Review Comment:
For example, the long value is -2198208304 (i.e., `negativeTs`) but int
value is 2096758992.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
