dongjoon-hyun commented on code in PR #43694: URL: https://github.com/apache/spark/pull/43694#discussion_r1384449877
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala: ########## @@ -785,17 +786,19 @@ case class Cast( buildCast[Boolean](_, b => if (b) 1 else 0) case DateType => buildCast[Int](_, d => null) - case TimestampType if ansiEnabled => + case TimestampType => buildCast[Long](_, t => { val longValue = timestampToLong(t) if (longValue == longValue.toInt) { longValue.toInt } else { - throw QueryExecutionErrors.castingCauseOverflowError(t, from, IntegerType) + if (ansiEnabled) { + throw QueryExecutionErrors.castingCauseOverflowError(t, from, IntegerType) + } else { + null + } Review Comment: Do you know when the current behavior was introduced, @viirya ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org