viirya commented on code in PR #43781: URL: https://github.com/apache/spark/pull/43781#discussion_r1393379712
########## docs/sql-ref-ansi-compliance.md: ########## @@ -240,6 +240,25 @@ The least common type resolution is used to: - Derive the result type for expressions such as the case expression. - Derive the element, key, or value types for array and map constructors. Special rules are applied if the least common type resolves to FLOAT. With float type values, if any of the types is INT, BIGINT, or DECIMAL the least common type is pushed to DOUBLE to avoid potential loss of digits. + +Decimal type is a bit more complicated here, as it's not a simple type but has parameters: precision and scale. +A `decimal(precision, scale)` means the value can has at most `precision - scale` digits in the integral part and `scale` digits in the fractional part. Review Comment: ```suggestion A `decimal(precision, scale)` means the value can have at most `precision - scale` digits in the integral part and `scale` digits in the fractional part. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
