viirya commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393385818
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4541,6 +4541,15 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_RETAIN_FRACTION_DIGITS_FIRST =
+
buildConf("spark.sql.legacy.decimalLeastCommonType.retainFractionDigitsFirst")
+ .internal()
+ .doc("When set to true, we will try to retain the fraction digits first
rather than " +
+ "integral digits, when getting a least common type between decimal
types, and the " +
+ "result decimal precision exceeds the max precision.")
Review Comment:
```suggestion
.doc("When set to true, we will try to retain the fraction digits
first rather than " +
"integral digits as prior Spark 4.0, when getting a least common
type between decimal types, and the " +
"result decimal precision exceeds the max precision.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
