ulysses-you commented on code in PR #43806:
URL: https://github.com/apache/spark/pull/43806#discussion_r1393580889
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryAdaptiveBroadcastExec.scala:
##########
@@ -44,9 +46,21 @@ case class SubqueryAdaptiveBroadcastExec(
throw
QueryExecutionErrors.executeCodePathUnsupportedError("SubqueryAdaptiveBroadcastExec")
}
+ override def equals(other: Any): Boolean = other match {
+ case x: SubqueryAdaptiveBroadcastExec => this.name == x.name && this.index
== x.index &&
+ this.onlyInBroadcast == x.onlyInBroadcast && this.buildPlan ==
x.buildPlan &&
+ this.buildKeys == x.buildKeys && this.child == x.child
+ case y: SubqueryBroadcastExec => this.name == y.name && this.index ==
y.index &&
+ this.buildKeys == y.buildKeys && this.child == y.child
Review Comment:
IIUC, when we replace SubqueryAdaptiveBroadcastExec to
SubqueryBroadcastExec, we would add a broadcast exchange on the top of child
then AQE would reuse the broadcast exchange. Then can
`SubqueryAdaptiveBroadcastExec.child` be same with
`SubqueryBroadcastExec.child`(broadcast exchange) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
