beliefer commented on code in PR #43806: URL: https://github.com/apache/spark/pull/43806#discussion_r1393856527
########## sql/core/src/main/scala/org/apache/spark/sql/execution/SubqueryAdaptiveBroadcastExec.scala: ########## @@ -46,7 +46,8 @@ case class SubqueryAdaptiveBroadcastExec( protected override def doCanonicalize(): SparkPlan = { val keys = buildKeys.map(k => QueryPlan.normalizeExpressions(k, child.output)) - copy(name = "dpp", buildKeys = keys, child = child.canonicalized) + SubqueryBroadcastExec(name = "dpp", index = index, buildKeys = keys, Review Comment: The implementation looks some against the design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org