cloud-fan commented on PR #43958: URL: https://github.com/apache/spark/pull/43958#issuecomment-1836129316
I don't see much value of this refactor. It doesn't reduce the code size much, and doesn't make the code more readable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
