cloud-fan commented on code in PR #43958:
URL: https://github.com/apache/spark/pull/43958#discussion_r1413421839
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##########
@@ -196,24 +225,16 @@ class FrameLessOffsetWindowFunctionFrame(
offset: Int,
ignoreNulls: Boolean = false)
extends OffsetWindowFunctionFrameBase(
- target, ordinal, expressions, inputSchema, newMutableProjection, offset) {
+ target, ordinal, expressions, inputSchema, newMutableProjection, offset,
ignoreNulls) {
- override def prepare(rows: ExternalAppendOnlyUnsafeRowArray): Unit = {
+ override def prepareForDefaultValue(rows: ExternalAppendOnlyUnsafeRowArray):
Unit = {
resetStates(rows)
Review Comment:
can we add comments to explain why this window frame need to reset states in
`prepareForDefaultValue`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
