Re: [PR] [SPARK-46366][SQL] Use WITH expression in BETWEEN to avoid duplicate expressions [spark]

[via GitHub]

dtenedor commented on code in PR #44299:
URL: https://github.com/apache/spark/pull/44299#discussion_r1427195654


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3436,6 +3437,21 @@ class Analyzer(override val catalogManager: 
CatalogManager) extends RuleExecutor
     }
   }
 
+  /**
+   * Transform UnresolvedBetweenExpression into a [BetweenExpr].
+   */
+  object ResolveBetweenExpression extends Rule[LogicalPlan] {

Review Comment:
   We should avoid trying to add new analyzer rules at this point. Could we 
accomplish this  by combining `UnresolvedBetweenExpression` and 
`ResolvedBetweeExpression` into just one `BetweenExpression` and make that 
inherit from `RuntimeReplaceable`? Then its `replacement` can be the `With` 
expression of interest.
   
   
![image](https://github.com/apache/spark/assets/99207096/f96c15a0-bd5a-4870-b13f-2150ff2e58ff)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org