cloud-fan commented on code in PR #44299:
URL: https://github.com/apache/spark/pull/44299#discussion_r1435164673
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/StreamingJoinHelper.scala:
##########
@@ -96,17 +96,22 @@ object StreamingJoinHelper extends PredicateHelper with
Logging {
// If state watermark is W, all state where timestamp <= W will be
cleaned up.
// Now when the canonicalized join condition solves to leftTime >= W, we
don't want to clean
// up leftTime <= W. Rather we should clean up leftTime <= W - 1. Hence
the -1 below.
- val stateWatermark = predicate match {
- case LessThan(l, r) => getStateWatermarkSafely(l, r)
- case LessThanOrEqual(l, r) => getStateWatermarkSafely(l, r).map(_ - 1)
- case GreaterThan(l, r) => getStateWatermarkSafely(r, l)
- case GreaterThanOrEqual(l, r) => getStateWatermarkSafely(r, l).map(_ -
1)
- case _ => None
- }
- if (stateWatermark.nonEmpty) {
- logInfo(s"Condition $joinCondition generated watermark constraint =
${stateWatermark.get}")
- }
- stateWatermark
+ val stateWatermarks = (predicate match {
Review Comment:
why do we change the streaming code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
