cloud-fan commented on code in PR #44480: URL: https://github.com/apache/spark/pull/44480#discussion_r1436434932
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala: ########## @@ -41,7 +41,7 @@ import org.apache.spark.sql.types._ * * Currently this only handles cases where: * 1). `fromType` (of `fromExp`) and `toType` are of numeric types (i.e., short, int, float, - * decimal, etc), boolean type or datetime type + * decimal, etc), boolean type or datetime type, or timestamp types Review Comment: datetime type includes timestamp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
