viirya commented on code in PR #44480: URL: https://github.com/apache/spark/pull/44480#discussion_r1436594451
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala: ########## @@ -144,6 +144,15 @@ object UnwrapCastInBinaryComparison extends Rule[LogicalPlan] { value != null => Some(unwrapTimestampToDate(be, fromExp, ts, timeZoneId, evalMode)) + // Timestamp/Timestamp_NTZ -> Timestamp_NTZ/Timestamp Review Comment: Added round trip check before the rewriting it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org