cloud-fan commented on code in PR #44261:
URL: https://github.com/apache/spark/pull/44261#discussion_r1437452061
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala:
##########
@@ -68,17 +68,17 @@ object ResolveInlineTables extends Rule[LogicalPlan]
/**
* Validates that all inline table data are valid expressions that can be
evaluated
* (in this they must be foldable).
- *
+ * Exception are CURRENT_LIKE expressions, which are replaced by a literal
in later stages.
* This is package visible for unit testing.
*/
private[analysis] def validateInputEvaluable(table: UnresolvedInlineTable):
Unit = {
table.rows.foreach { row =>
row.foreach { e =>
- // Note that nondeterministic expressions are not supported since they
are not foldable.
Review Comment:
Shall we keep this line of comment about nondeterministic expressions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
