cloud-fan commented on code in PR #44261: URL: https://github.com/apache/spark/pull/44261#discussion_r1437461055
########## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala: ########## @@ -100,10 +104,10 @@ class EliminateSortsSuite extends AnalysisTest { val query = x.select($"a".as("x"), Year(CurrentDate()).as("y"), $"b") Review Comment: This test does not need to use `CurrentDate` at all. Let's change it to use `rand().as("y")` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org