Ngone51 commented on code in PR #43954:
URL: https://github.com/apache/spark/pull/43954#discussion_r1448181728
##########
core/src/test/scala/org/apache/spark/TempLocalSparkContext.scala:
##########
@@ -51,7 +51,7 @@ trait TempLocalSparkContext extends BeforeAndAfterEach
*/
def sc: SparkContext = {
if (_sc == null) {
- _sc = new SparkContext(_conf)
+ _sc = new SparkContext(conf)
Review Comment:
No. `conf` allow us to use the custom conf from inherit classes. But
`_conf` are hard-coded to `defaultSparkConf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
