cloud-fan commented on code in PR #43954: URL: https://github.com/apache/spark/pull/43954#discussion_r1448202635
########## core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala: ########## @@ -1002,6 +1002,17 @@ private[spark] class TaskSetManager( maybeFinishTaskSet() } + // Suspends this TSM to avoid launching new tasks. + // + // Unlike `abort()`, this function intentionally to not notify DAGScheduler to avoid + // redundant operations. So the invocation to this function should assume DAGScheduler + // already knows about this TSM failure. For example, this function can be called from + // `TaskScheduler.cancelTasks` by DAGScheduler. Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org