HeartSaVioR commented on code in PR #45038: URL: https://github.com/apache/spark/pull/45038#discussion_r1487154735
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala: ########## @@ -92,10 +108,17 @@ private[sql] class RocksDBStateStoreProvider override def prefixScan(prefixKey: UnsafeRow, colFamilyName: String): Iterator[UnsafeRowPair] = { - require(encoder.supportPrefixKeyScan, "Prefix scan requires setting prefix key!") - - val prefix = encoder.encodePrefixKey(prefixKey) - rocksDB.prefixScan(prefix, colFamilyName).map(kv => encoder.decode(kv)) + val kvEncoder = keyValueEncoderMap.get(colFamilyName) + require(kvEncoder._1.supportPrefixKeyScan, + "Prefix scan requires setting prefix key!") + + val prefix = kvEncoder._1.encodePrefixKey(prefixKey) + rocksDB.prefixScan(prefix, colFamilyName).map { kv => + val rowPair = new UnsafeRowPair() Review Comment: Please create this outside of lambda if it works - if we are creating pair object per kv, it's no meaning of reusing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org